-
Notifications
You must be signed in to change notification settings - Fork 16
Reimplement open boundary conditions #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it crashes when the particles are dropped, it seems
tests show the same magnitude of failure as before
and maybe fix bounds
germasch
reviewed
Jan 30, 2026
Contributor
germasch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some minor things to comment on ;)
germasch
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Unfortunately, there are gauss errors at open boundaries. I believe they are false positives caused by inaccurate ghost electric fields. I can think of two possible solutions to this:
a) Communicate ghost corners in the ghost region beyond open BCs
b) Move the particle injection/deletion region to inside the domain
For now, I take solution c), ignore the problem and just deal with the erroneous gauss errors.
Elaborating on the inaccurate ghost electric field:
Consider a particle at the top of a patch, moving left. When it exits the patch, it deposits current in the ghost cells on the left, including some ghost cells in the upper-left corner. The ghost currents in that corner don't get communicated, and thus aren't used to time-evolve the ghost electric fields used by the gauss check, leading to a false positive error. Continuity checks are likely similarly affected.